fix(number): values out of bounds #1648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ST-DDT
added
c: bug
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #1648 +/- ##
=======================================
Coverage 99.62% 99.63%
=======================================
Files 2222 2222
Lines 240507 240514 +7
Branches 1067 1073 +6
=======================================
+ Hits 239605 239636 +31
+ Misses 881 857 -24
Partials 21 21
|
Shinigami92
added
p: 1-normal
Shinigami92
approved these changes
Dec 9, 2022
xDivisionByZerox
approved these changes
Dec 9, 2022
ejcheng
approved these changes
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1595
This PR fixes the issue caused by number.int returning values out of bounds, if the given min and max aren't integers themselves.
This also causes number.float to return values out of bounds.
Case 1:
int({min: 2.1, max: 2.9})Previously -> 2 or 3
Now -> Error
Case 2:
int({min: 1.1, max: 2.9})Previously -> 1, 2 or 3
Now -> 2